xunit/xunit

InlineData duplicate detection fails to detect duplicates between implicitly converted types

Open

#2,957 opened on Jun 22, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (761 forks)batch import
AnalyzersBughelp wanted

Repository metrics

Stars
 (3,873 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Given the following code:

    public const int Const = 1;
    public const byte ConstByte = 1;

    [Theory]
    [InlineData(Const)]
    [InlineData(ConstByte)]
    public void Test(int a) { }

No diagnostics are raised by the analyzer despite both these inputs resulting in exactly the same test being run. Somewhat related to https://github.com/xunit/xunit/issues/1742, with the major difference being that these tests run just fine without any issues.

Contributor guide

Research direction
Investigate the xUnit analyzer's duplicate detection logic to see how it compares InlineData values and why it fails to consider implicit numeric conversions. Determine if the comparison is done on the raw expression or after implicit conversion.
Tech stack
csharp
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#xUnit basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70