xtuc/webassemblyjs

run the unit tests through babel

Open

#125 opened on Jan 30, 2018

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (742 stars) (96 forks)batch import
good first issue

Description

Currently the unit tests are run against the transpiled code in the lib folder. This has a few issues:

  1. it increases the build / test time
  2. the test code can only use language features currently supported node
  3. the import statements in test code reference the transpiled output, which makes it hard to navigate failure stack traces.
  4. We don't have any flow-typing for the unit test code

Ideally mocha would be run through babel - with source maps.

Contributor guide

Tech stack
javascriptnodejs
Domain
testingbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Mocha test runnerBabel configurationNode.js basicsSource map fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current test setup in package.json and any mocha configuration files. Modify the test script to run mocha with ` require @babel/register` and enable source maps. Ensure that babel is configured to transpile ES modules for Node. Test the changes by running the unit tests and verifying stack traces point to original source files.