xtermjs/xterm.js

Search is not incremental

Open

#5,177 opened on Oct 3, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (16,196 stars) (1,574 forks)batch import
area/addon/searcharea/performancehelp wantedtype/bug

Description

See https://github.com/xtermjs/xterm.js/issues/5176 for context

All searches take the same amount of time when the latter ones should take much less time due to being incremental:

Test file:

test.txt

Image

Contributor guide

Tech stack
typescript
Domain
frontendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of search algorithmsfamiliarity with xterm.js addons
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Refer to the linked issue #5176 for context. The search is implemented in the search addon of xterm.js. Investigate the existing search implementation (likely in src/addons/search/) to understand why each search iteration is not incremental. Look for opportunities to memoize or cache results from previous searches to reduce time for subsequent searches.