xtermjs/xterm.js

Support 'px' format in lineHeight option

Open

#2,612 opened on Dec 6, 2019

View on GitHub
 (5 comments) (1 reaction) (1 assignee)TypeScript (16,196 stars) (1,574 forks)batch import
good first issuehelp wantedtype/enhancement

Description

Now the LineHeight can only be propagated to the number type like 1.2.

There is a very uncomfortable scenario:

I chose to use DOM to render，Then the contents of the subdiv of xterm-rows, as shown below, are determined based on the configuration items, such as 1.2, and the calculated value is 21px：

image

I want to set LineHeight to 23px, then I need to set LineHeight to 1.3, but I don't know how to turn 23 to 1.3

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScriptUnderstanding of xterm.js renderingFamiliarity with lineHeight option
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue requests support for 'px' format in lineHeight. Examine how lineHeight is currently handled in src/InputHandler.ts or similar files where rendering properties are processed. Look for comments from maintainers on the feasibility. Consider modifying the lineHeight option to accept both number (interpreted as multiplier) and string with 'px' suffix (interpreted as fixed pixel value). Ensure compatibility with existing behavior and test edge cases.