xtermjs/xterm.js

Cursor is not visible on inverted text

Open

#2064 opened on May 11, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (16,196 stars) (1,574 forks)batch import
area/addon/webglarea/renderer-domhelp wantedtype/bug

Description

Here's what it looks like in vscode (before and after 3.13, dom or canvas renderer), it happens in demo the same way (viewing italic text in a markdown file on vim):

Terminal.app:

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
xterm.js rendering pipelineTypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how inverted text is rendered in both DOM and canvas renderers. Check the cursor rendering logic in src/renderer/dom and src/renderer/canvas. Look for any color inversion or alpha blending issues that might cause the cursor to become invisible.