xtermjs/xterm.js

Handling transparent BG color when used as FG

Open

#1898 opened on Jan 16, 2019

View on GitHub
 (20 comments) (3 reactions) (1 assignee)TypeScript (16,196 stars) (1,574 forks)batch import
area/addon/webglarea/renderer-domgood first issuehelp wantedtype/bug

Description

Nano displays its shortcuts with FG/BG colors reversed: image

However, when theme BG is transparent, following happens: image

The solution could be to have a separate flag that will render characters with no background as if background were transparent instead of theme.backgroundColor, but will still use the actual color for inverted elements.

Contributor guide

Tech stack
typescriptcsshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with TypeScriptUnderstanding of terminal rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how foreground/background colors are handled in the rendering pipeline, focusing on the `renderer` and `Terminal` classes. Check the assignee's status to confirm availability. The suggested solution involves a flag to treat transparent backgrounds differently for inverted elements.