xtermjs/xterm.js

Move away from keyCode in keyboard handling

Open

#1,862 opened on Dec 27, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (1,574 forks)batch import
help wantedtype/debt

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 2d 10h) (16 merged PRs in 30d)

Description

KeyboardEvent.keyCode is deprecated, we should move to use key and code instead within Keyboard.ts. Some context: https://github.com/xtermjs/xterm.js/pull/1849#issuecomment-449408354

Contributor guide

Research direction
Replace deprecated `keyCode` with `key` and `code` in keyboard event handlers in Keyboard.ts. Update tests accordingly.
Tech stack
typescript
Domain
frontendweb dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80