xtermjs/xterm.js

Move away from keyCode in keyboard handling

Open

#1862 opened on Dec 27, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (16,196 stars) (1,574 forks)batch import
help wantedtype/debt

Description

KeyboardEvent.keyCode is deprecated, we should move to use key and code instead within Keyboard.ts. Some context: https://github.com/xtermjs/xterm.js/pull/1849#issuecomment-449408354

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of KeyboardEventFamiliarity with xterm.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate Keyboard.ts in the src/ directory. Replace all uses of event.keyCode with event.key and event.code, handling fallbacks if needed. Review the linked PR #1849 for additional context. Test with various keyboard inputs to ensure no regression.