xtermjs/xterm.js

Auto fit addon doesn't work when parent element uses border-box

Open

#1,283 opened on Feb 12, 2018

View on GitHub
 (4 comments) (0 reactions) (1 assignee)TypeScript (1,574 forks)batch import
area/addon/fitgood first issuehelp wantedtype/bug

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 2d 10h) (16 merged PRs in 30d)

Description

The calculations for height and width of the parent in the auto fit plugin are incorrect when the parent element uses box-sizing: border-box. This is because the computed height includes the padding but the content does not.

The right implementation might be to get the client height of the parent element using gBCR and then subtract the parent padding.

/CC @taion

Contributor guide

Research direction
Investigate the fit addon code to understand how parent dimensions are calculated. Test with box sizing: border box on parent. Consider using getBoundingClientRect and subtracting padding as suggested.
Tech stack
typescripthtmlcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript/TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75