Setting the Id or adding any attributes to a AudioMessage results in a duplicate key exception.
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- audio-video-rtc
Research direction
Start with AudioHostApplicationClient.GetOrCreateString() and the LibVst implementation of AudioHostAppication.TryCreateMessage(). Trace how the messageId and named attributes are stored, then verify that creating an AudioMessage assigns its id and setting attributes no longer raises the duplicate-key exception.
Written by the indexing model from the issue text.
Description
Whenever an AudioMessage is created via AudioHostAppication.TryCreateMessage(), a blank message is returned without an id. The messageId parameter passed to TryCreateMessage appears to be unused in the LibVst implementation of AudioHostAppicationClient. Furthermore, setting the message id manually or setting any named attribute results in an ArgumentException specifying "An item with the same key has already been added." It looks like this is happening because inside AudioHostApplicationClient.GetOrCreateString(), a call is made to CollectionMarshal.GetValueRefOrAddDefault(). Later in the function Add() is being called on the dictionary to set the allocated string pointer, but the value gets added as a default by the CollectionMarshal call.
- Dominant language
- C#
- Stars
- 152
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from xoofx/NPlug
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
question
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
question
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
UI/Midi Events Openquestion
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
enhancement PR welcome question
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:auth FE mvp P3
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
klasolsson81/jobbliggaren#1788 ·