xmartlabs/XLForm

App Rejected Due to Missing NSPhotoLibraryUsageDescription

Open

#891 opened on Oct 26, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Objective-C (5,786 stars) (969 forks)batch import
enhancementhelp wanted

Description

I had an app using this library get rejected for a missing NSPhotoLibraryUsageDescription when submitting with Xcode 8. I think it's due to the use of UIImagePickerController in XLFormImageCell.

My app doesn't use this cell or access the user's photo library in any way, so I'd prefer to not have to set a fake usage description. Is there any way to conditionally not compile this class, or create a CocoaPod subspec that doesn't include the XLFormImageCell?

Thanks

Contributor guide

Tech stack
objective cios
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
iOS developmentCocoaPodsXLForm project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the XLForm.podspec to understand how components are included. Look at XLFormImageCell to see if it can be conditionally compiled using preprocessor macros. Check existing issues for similar requests. Consider creating a subspec without the image cell or adding a compile time flag to exclude it.