xmartlabs/XLForm

formViewController assumes XLFormViewController is in the responder chain

Open

#720 opened on Feb 5, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Objective-C (5,786 stars) (969 forks)batch import
help wanted

Description

The method formViewController in XLFormBaseCell.m tries to get the form VC associated with the cell by climbing up the responder chain until it hits any VC. This seems like a bad assumption and here's why:

It's a generally accepted practice to have a VC (A) own another VC (B) using the child view controller array and add B's view to A. In that case, B will no longer be in the responder chain (I actually didn't know this, go figure) and the assumption made above is then violated. I have a case like this because I'm using the view of an XLFormVIewController as a subview of a monolithic VC. This is breaking the formViewController method and wreaking all sorts of havoc.

My interim fix will be to overwrite that method with a category extension to do some special logic that handles my case. In general, though, maybe cells should just keep a weak reference to their XLFormViewController if they really need it? This feels like a more sound approach.

Contributor guide

Tech stack
objective c
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
iOS developmentObjective Cresponder chain
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes changing the formViewController method in XLFormBaseCell.m to use a weak reference to the XLFormViewController instead of traversing the responder chain. A potential fix involves adding a weak property to the cell and setting it when the cell is configured. The maintainer should review the approach and ensure backward compatibility.