xmartlabs/Eureka

iOS 12 - SliderRows with images are not displaying correctly.

Open

#1,670 opened on Sep 27, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (1,317 forks)batch import
difficulty: moderatehelp wantedrow: SliderRowtype: issue

Repository metrics

Stars
 (11,820 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Since iOS 12, SliderRows with images are not displaying correctly. Only when I remove SliderRow cell imageView it's display correctly. I'm using Eureka 4.3.0


<<< SliderRow(){ row in
                row.title = "Voice speed"
                row.cell.imageView?.image = UIImage(named: "settings-rabbit")
                row.value = 50
                row.cell.slider.minimumValue = 1
                row.cell.slider.maximumValue = 100
            }

<<< SliderRow(){ row in
                row.title = "Voice pitch"
                row.cell.imageView?.image = UIImage(named: "settings-pitch")
                row.value =  50
                row.cell.slider.minimumValue = 1
                row.cell.slider.maximumValue = 100
            }

iOS 12 - SliderRows with image simulator screen shot - iphone x - 2018-09-27 at 05 22 46

iOS 12 - SliderRows without image simulator screen shot - iphone x - 2018-09-27 at 05 46 27

Contributor guide

Research direction
Check the auto layout constraints of the SliderRow cell's imageView on iOS 12. Compare with behavior on earlier iOS versions. Investigate changes in UITableViewCell layout margins or imageView positioning in iOS 12.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65