xmartlabs/Eureka

iOS 12 - SliderRows with images are not displaying correctly.

Open

#1670 opened on Sep 27, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (11,820 stars) (1,317 forks)batch import
difficulty: moderatehelp wantedrow: SliderRowtype: issue

Description

Since iOS 12, SliderRows with images are not displaying correctly. Only when I remove SliderRow cell imageView it's display correctly. I'm using Eureka 4.3.0


<<< SliderRow(){ row in
                row.title = "Voice speed"
                row.cell.imageView?.image = UIImage(named: "settings-rabbit")
                row.value = 50
                row.cell.slider.minimumValue = 1
                row.cell.slider.maximumValue = 100
            }

<<< SliderRow(){ row in
                row.title = "Voice pitch"
                row.cell.imageView?.image = UIImage(named: "settings-pitch")
                row.value =  50
                row.cell.slider.minimumValue = 1
                row.cell.slider.maximumValue = 100
            }

iOS 12 - SliderRows with image simulator screen shot - iphone x - 2018-09-27 at 05 22 46

iOS 12 - SliderRows without image simulator screen shot - iphone x - 2018-09-27 at 05 46 27

Contributor guide

Tech stack
swiftios
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftiOS developmentEureka libraryAuto Layout
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate iOS 12 specific changes to cell layout that may affect SliderRow imageView. Check the SliderRow source code (likely in Source/Rows/SliderRow.swift) for constraints or layout code. Compare with earlier iOS versions to identify what changed. Also verify if there is a known fix in later Eureka versions (e.g., 5.x) and if the issue can be resolved by updating constraints or using stack views.