xgfe/react-native-datepicker

Please put example code in sub directory

Open

#81 opened on Feb 9, 2017

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (2,109 stars) (737 forks)batch import
enhancementhelp wanted

Description

Hi, thanks for the great work. When I initially saw your codebase, I thought this was a React Native bridge module, but then came to understand it was a JS-only package. This is because I saw the android and ios directories. Also I was confused at index.ios.js and index.android.js files.

Typically in a RN library you put example code in a sub directory called Example or whatever. This will eliminate any confusion. If you need help, let me know and I'll create a PR for it

Contributor guide

Tech stack
react nativejavascriptandroidios
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React Native project structureBasic knowledge of file organization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
First, examine the repository's root directory structure to locate existing example files (e.g., index.ios.js, index.android.js) and the android/ and ios/ directories. Then create an 'Example' subdirectory and move those files into it. Update any import paths within the moved files to reflect the new location. Also check the README or other documentation for references to the example code and update those paths accordingly. Ensure the example still works after the move.