Propertygrid user input data validation issue
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
Start with the supplied WPF reproduction at XctkPropertyGrid and PropertyGrid_Loaded, using the Person and Person2 examples. Trace how PropertyGrid handles IDataErrorInfo and DataAnnotations validation during editing and focus loss. No repository file or test is identified; done means invalid input shows appropriate feedback and the error state clears when the value becomes valid.
Written by the indexing model from the issue text.
Description
question1: [Range()] causes the UI to have no user error prompts
//test example as follow:
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Runtime.CompilerServices;
namespace WpfApp1
{
public class Person: INotifyPropertyChanged, IDataErrorInfo
{
[Required(ErrorMessage = "Name is Required")]
[DisplayName("Name")]
public string Name { set; get; }
[Range(0,150,ErrorMessage = "Age= 0~150")]
[DisplayName("Age")]
public int Age { set; get; }
public event PropertyChangedEventHandler? PropertyChanged;
[Browsable(false)]
public string Error { get; }
public string this[string propertyName]
{
get
{
if (string.IsNullOrEmpty(propertyName))
{
throw new ArgumentException("Invalid property name", propertyName);
}
string error = string.Empty;
var val = GetType().GetProperty(propertyName).GetValue(this, null);
var results = new List<System.ComponentModel.DataAnnotations.ValidationResult>(1);
var result = Validator.TryValidateProperty(val, new ValidationContext(this, null, null)
{ MemberName = propertyName }, results);
if (!result)
{
var validationResult = results.First();
error = validationResult.ErrorMessage;
}
return error;
}
}
protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) => this.OnPropertyChanged(new PropertyChangedEventArgs(propertyName));
protected virtual void OnPropertyChanged(PropertyChangedEventArgs args)
{
PropertyChangedEventHandler propertyChanged = this.PropertyChanged;
if (propertyChanged == null)
return;
propertyChanged((object)this, args);
}
}
}
<xctk:PropertyGrid Name="XctkPropertyGrid" Loaded="PropertyGrid_Loaded"></xctk:PropertyGrid>
private void PropertyGrid_Loaded(object sender, RoutedEventArgs e)
{
Person p = new Person(){Age = 20,Name = "wala"};
this.XctkPropertyGrid.SelectedObject = p;
}
[Range (0150, ErrorMessage="Age=0-150")] can prevent users from entering illegal values, but there is no red box mark or error prompt. Debugging found that this [string propertyName] indexer has not been called because it prevents users from entering illegal values.
question2:use person2 insteadof person1,When the user inputs an incorrect value, a red boder will prompt, but when the user leaves the attribute input box, the value in the red boder will return to the legal value, but the red boder will not disappear.
public class Person2 : INotifyPropertyChanged, IDataErrorInfo
{
[DisplayName("Name")]
public string Name { set; get; }
private int _age;
[DisplayName("Age")]
public int Age {
set
{
if (!ValidataProperty(nameof(Age), value))
return;
_age = value;
RaisePropertyChanged(nameof(Age));
}
get
{
return _age;
}}
public event PropertyChangedEventHandler? PropertyChanged;
[Browsable(false)]
public string Error { get; }
protected bool ValidataProperty(string propertyName, object val)
{
if (propertyName.Equals(nameof(Age)))
{
int ageVal = (int)val;
if (ageVal < 0 || ageVal > 150)
{
ErrorProperty = propertyName;
ErrorMsg = "Age =0~150";
return false;
}
}
ErrorMsg = string.Empty;
ErrorProperty = string.Empty;
return true;
}
private string ErrorProperty;
private string ErrorMsg;
public string this[string propertyName]
{
get
{
if (ErrorProperty.Equals(propertyName))
{
return ErrorMsg;
}
return string.Empty;
}
}
protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) => this.OnPropertyChanged(new PropertyChangedEventArgs(propertyName));
protected virtual void OnPropertyChanged(PropertyChangedEventArgs args)
{
PropertyChangedEventHandler propertyChanged = this.PropertyChanged;
if (propertyChanged == null)
return;
propertyChanged((object)this, args);
}
}
- Dominant language
- C#
- Stars
- 4.2k
- Forks
- 912
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from xceedsoftware/wpftoolkit
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
xceedsoftware/wpftoolkit#1808 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
xceedsoftware/wpftoolkit#1807 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
xceedsoftware/wpftoolkit#1806 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
xceedsoftware/wpftoolkit#1804 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
xceedsoftware/wpftoolkit#1802 · 3 comments ·
All issues in xceedsoftware/wpftoolkit
Similar issues
-
untriaged
Difficulty 1/5 Under an hour Newbie friendliness 88/100
dotnet/dotnet-api-docs#13095 ·
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
newrelic/newrelic-dotnet-agent#3850 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
LuckyPennySoftware/AutoMapper#4660 ·