update fixtures in future

Open
#113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
numpy, python
Domain
testing-qa

Research direction

Locate the geom_array fixture and inspect where it is repeatedly created as a NumPy array and cast to a GeometryArray. Check the minimum xarray version and its extension-array roundtrip behavior before changing the fixture. Done means the fixture is natively a GeometryArray when that xarray support is available and the affected test suite still passes.

Written by the indexing model from the issue text.

Description

I think the whole test suite would benefit from a pass through at some point. The geom_array fixture is used repeatedly as a numpy array and then cast to a GeometryArray, it seems, to make testing for equality easier when xarray didn't handle this extension array stuff natively. So perhaps once the minimum version is bumped to a version of xarray where this geometry array type is preserved on the roundtrip, you can make geom_array natively as a fixture an extension array.

Originally posted by @ilan-gold in https://github.com/xarray-contrib/xvec/issues/112#issuecomment-2845094426

Dominant language
Python
Stars
139
Forks
14
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from xarray-contrib/xvec

All issues in xarray-contrib/xvec

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.