xamarin/Xamarin.Forms

Activity restarts with resolution change, page UI doesnt change

Open

#7,239 opened on Aug 22, 2019

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/2 :clock2:hacktoberfest 🍻help wantedin-progressinactivep/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Activity restart doesn't update the page layout, it measure the layout according to last density not the one which has been selected from device setting's resolution change option.

Steps to Reproduce

  1. open xamarin forms app
  2. put app in background and go to settings
  3. search for device resolution option
  4. change it to other resolution and open the app from background
  5. check the page resolution

Class where the cache issue is : https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/ContextExtensions.cs

property name : s_displayDensity

Expected Behavior

Actual Behavior

Basic Information

  • Version with issue:

  • Last known good version:

  • IDE:

  • Platform Target Frameworks:

    • iOS: 10.0
    • Android: 7.0

  • Affected Devices: Samsung devices, not sure about other devices

Contributor guide

Research direction
Inspect the static field s displayDensity in ContextExtensions.cs and understand why the cached density is not updated on resolution change. Trace how the density is retrieved and consider whether it should be refreshed on activity restart.
Tech stack
csharpandroid
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65