xamarin/Xamarin.Forms

[Bug] [Shell] Bottom tab back navigation is not working on Android

Open

#7,081 opened on Aug 6, 2019

View on GitHubContributor guide
 (4 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
e/3 :clock3:help wantedp/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

On android, when using bottom tabs in shell, if I navigate to a new page and then navigate back by using the bottom tab bar, no navigation occurs. I am forced to use the back button.

Steps to Reproduce

  1. Create an app with shell and set up 2 bottom tabs.
  2. Push a new page onto the navigation stack using Shell's GoToAsync call
  3. Attempt to navigate back by pressing the bottom tab bar button.

Expected Behavior

I am able to navigate back to the previous page

Actual Behavior

No navigation happens.

Basic Information

  • Version with issue: Forms 4.1
  • Last known good version: none that I know of
  • IDE: windows and mac
  • Platform Target Frameworks: Latest

Reproduction Link

Repro Project

This project is the basic shell template when making a new shell project. I changed the navigation to the item details to using a shell route instead of using the page INavigation property.

Extra info

Navigating back is the behavior found on other android apps with bottom nav bars (Target, YouTube, Spotify).

Contributor guide

Research direction
Investigate the Shell bottom tab bar navigation logic on Android, specifically the handling of tab selection when there is a pushed page on the navigation stack. Look at the ShellItemRenderer or BottomTabbedRenderer to understand why tapping a tab does not navigate back but the back button does.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms Shell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60