xamarin/Xamarin.Forms

[Bug] Carousel Page within a NavigationPage causes unwanted Margin to appear at bottom on iOS if secondary toolbar items exist.

Open

#6,858 opened on Jul 11, 2019

View on GitHubContributor guide
 (6 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Was working fine before changing to a carousel page. It's OK in Android. Structure is CarouselPage->ContentPage->Grid->ListView <Grid.RowDefinitions> <RowDefinition Height="*" />(ListView) <RowDefinition Height="Auto" />(Input bar) </Grid.RowDefinitions>

Expected Behavior

Input bar sits at bottom of screen because first grid row is * height.

Actual Behavior

Input bar sits above bottom of screen.

  • Version with issue: 4.1.555618
  • Last known good version:N/A
  • IDE: Visual Studio 2017
    • iOS: 12.0
    • Android: N/A
  • Affected Devices:iPhone 8 (real and simulator)

Repro

CarouselPageDemo.zip

Contributor guide

Research direction
Investigate why secondary toolbar items cause extra margin at bottom on iOS in CarouselPage. Check layout calculations and toolbar rendering.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Xamarin.FormsiOS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50