xamarin/Xamarin.Forms

Setting IsPullToRefreshedEnabled of a custom ListView through a XAML style does not work

Open

#6,780 opened on Jul 4, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/listviewa/stylee/4 :clock4:help wantedp/Androidp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I have a custom ListView that enables pull to refresh by default. If I use this class in XAML and set IsPullToRefreshEnabled to false through a style, it does NOT work.

Steps to Reproduce

  1. Run the attached repro on Android or iOS
  2. Observe that the background color of the list is set through the style
  3. Observe that pull to refresh is enabled by default in CustomListView
  4. Finally observe that pull to refresh is still enabled in MainPage's list even though the style wants to disable it

Expected Behavior

XAML styles should be able to override IsPullToRefreshEnabled in a custom control

Actual Behavior

Styles cannot override IsPullToRefreshEnabled.

Reproduction Link

App14.zip

Contributor guide

Research direction
Investigate why XAML styles fail to override IsPullToRefreshEnabled in a custom ListView. Check if the property is set as a dependency property with proper metadata, and examine the style precedence in Xamarin.Forms.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAMLXamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60