xamarin/Xamarin.Forms

[Bug] Icon not correctly centered with text when using FontImageSource

Open

#6,632 opened on Jun 23, 2019

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
e/5 :clock5:help wantedp/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

In a button, icon is not correctly centered with the text.

Steps to Reproduce

  1. Add a button to a page with a text and an icon using FontImageSource
  2. Set ContentLayout property of the button to "Left,0"
  3. Launch the app an go to the page

Expected Behavior

Icon and text are centered in the button, the icon appears just on the left of the text without space between them.

Actual Behavior

Text is centered in the button but the icon is not, there is a lot of space between text and button. It seems that ContentLayout property is not taken into account.

Basic Information

  • Version with issue: Xamarin Forms 4.1
  • IDE: VS 2019
  • Platform Target Frameworks: Only tested on Android
    • Android: 9.0
  • Nuget Packages: Nuget from the default Shell templates
  • Affected Devices: All devices

Screenshots

FontImageSource_Issue

The button "SomeText" on the screenshot shows the icon not correctly centered.

Reproduction Link

Github repo : https://github.com/TechWatching/FontImageSourceIssue

Contributor guide

Research direction
Investigate how the ContentLayout property is applied to buttons with FontImageSource, focusing on the Android platform renderer.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50