xamarin/Xamarin.Forms

[Bug] Material Entry TextColor does not update correctly

Open

#6,571 opened on Jun 18, 2019

View on GitHub
 (0 comments) (6 reactions) (0 assignees)C# (5,644 stars) (1,926 forks)batch import
a/visuale/2 :clock2:good first issuehackathonhelp wantedinactivep/Androidp/iOS 🍎t/bug :bug:up-for-grabs

Description

Description

When the TextColor of an Entry with the Material Visual applied is set, the change does not visually occur on the native control until another property (such as PlaceholderColor) is changed.

Steps to Reproduce

  1. Place an Entry with Visual=Material on a page.
  2. Change the value of the Entry's TextColor property to something other than Color.Default
  3. Change the value of the Entry's PlaceholderColor property to something other than Color.Default

Expected Behavior

Entry text color changes when TextColor property is set.

Actual Behavior

Entry text color does not update until the placeholder color is also updated.

Basic Information

  • Version with issue: Tested on 3.6.0.344457, 4.0.0.497661, 4.1.0.496342-pre2
  • Last known good version: None
  • IDE: Visual Studio Enterprise 2019
  • Platform Target Frameworks:
    • iOS: 12.2
    • Android: 9.0
  • Android Support Library Version: 28.0.0.1
  • Nuget Packages:
    • Xamarin.Forms
    • Xamarin.Forms.Visual.Material

Reproduction Link

MaterialEntryTextColor.zip

Contributor guide

Tech stack
csharp
Domain
mobilefrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C#Xamarin.FormsMaterial Visual
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Material Entry renderer in Xamarin.Forms, specifically the 'MaterialEntryRenderer' class. The issue likely involves the property changed handler for TextColor not properly invalidating the native control. Check how PlaceholderColor triggers an update and see if TextColor's update logic is missing a call to update the native text color. The reproduction steps and sample are provided in the issue. No existing pull requests or assignees, so this is open for contribution.