xamarin/Xamarin.Forms

[Bug] Material Activity Indicator has unusual large size on iOS

Open

#6,374 opened on May 31, 2019

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
a/visuale/3 :clock3:help wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

On iOS devices, the Activity Indicator with Visual property set to Material takes a large size. This occurs when either WidthRequest or HeightRequest properties are not set.

Steps to Reproduce

  1. Create ActivityIndicator control in xaml.
  2. Set Visual property to Material
  3. Don't set HeightRequest and WidthRequest properties to the control.

Expected Behavior

The Material Activity Indicator should take the default dimensions of 48x48 as specified in google_material_docs

Actual Behavior

The Material Activity Indicator takes up a large size

Basic Information

  • Version with issue: Xamarin.Forms 4.0.0.394984-pre10, Xamarin.Forms.Visual.Material 4.0.0.394984-pre10.

I have also tried with stable version Xamarin Forms 4.0.0.471375 and Xamarin.Forms.Visual.Material 4.0.0.471375

  • Last known good version:
  • IDE: VS2019
  • Platform Target Frameworks:
    • iOS: 11
  • Affected Devices: All iOS devices

Screenshots

ezgif com-optimize

Reproduction Link

I have noticed this bug in Hanselman.Forms repo on the PodcastDetailsPage. Here is the issue which tracks it. A temporary workaround is to set the WidthRequest to 48

Note

However I have tried this in the MaterialActivityIndicatorGallery by removing the HeightRequest, but the bug does not appear.

Contributor guide

Research direction
Examine the Material ActivityIndicator renderer for iOS (likely in Xamarin.Forms.Platform.iOS) to understand why the default size is larger than 48x48 when WidthRequest and HeightRequest are not set. Check if the renderer sets a default size or if the native UIActivityIndicatorView's intrinsic size is not being constrained. Look for any layout logic that might be causing the control to expand to fill available space.
Tech stack
csharpios
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70