xamarin/Xamarin.Forms

Xaml Parser/Compiler does not identify invalid Xaml

Open

#5,947 opened on Apr 18, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)C# (1,926 forks)batch import
a/Xaml </>e/2 :clock2:good first issuehelp wantedinactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

The following Xaml, is invalid and does not produce a valid page, but it compiles and parses

Steps to Reproduce

  1. Clone Repo:
  2. Build and Run on iOS
  3. Add an extra > on line 29

Expected Behavior

Compile/Parse error

Actual Behavior

Compiles and parses but does not display right

Reproduction Link

https://github.com/Clancey/gMusic.Forms/

Contributor guide

Research direction
Examine the XAML parsing code path in Xamarin.Forms to identify where the validation of tag syntax is missing or insufficient.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65