xamarin/Xamarin.Forms

[Bug] Shell treats Show/Hide Flyout Differently from TabBar and NavBar

Open

#5,940 opened on Apr 17, 2019

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C# (5,644 stars) (1,926 forks)batch import
4.0.0a/shell :shell:e/2 :clock2:good first issuehelp wantedinactivet/bug :bug:up-for-grabs

Description

Description

From anywhere in the app you can toggle the FlyoutBehavior, but the same cannot be done for the bottom tabs or navigation bar which only seem to work at the page level.

Shell.SetFlyoutBehavior(Shell.Current, Xamarin.Forms.FlyoutBehavior.Disabled);
Shell.SetTabBarIsVisible(Shell.Current, true);

The latter call above won't do anything unless the bindable object is the page.

https://www.screencast.com/t/UgWadR6WTu1X

Expected Behavior

I should be able to call the static method SetTabBarIsVisible as well as SetNavBarIsVisible and see it applied globally.

I should be able to also continue doing this for each page.

Basic Information

  • Version with issue: 4.0-pre8
    • iOS: 12.1

Didn't test on Android.

Reproduction Link

https://github.com/davidortinau/Xappy

Contributor guide

Tech stack
csharpiosandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Xamarin.Forms Shellattached propertiesC# basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate how Shell.SetTabBarIsVisible and Shell.SetNavBarIsVisible are implemented compared to SetFlyoutBehavior. Check Shell.cs and attached property registration. The reproduction link is at https://github.com/davidortinau/Xappy. Comments on the issue may provide additional context. The fix likely involves ensuring the attached property is applied to the Shell element globally, not just at the page level.
[Bug] Shell treats Show/Hide Flyout Differently from TabBar and NavBar · xamarin/Xamarin.Forms#5940 | Good First Issue