xamarin/Xamarin.Forms

Android + Visual + Focus is wonky

Open

#5,366 opened on Feb 25, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
4.1.0a/visuale/5 :clock5:help wantedinactivep/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am not sure of all the things, but for some reason the whole focus things for Android controls (appears to be certain Material controls) is going wonky. It might also be the "fast renderer" part, but can't say for sure as there are not that many other fast renderers.

For example, if you tap the material page with sliders: android-focus

I added all sorts of focus-change listeners and events, but nothing appears to trigger. It looks to be a "visually focus, but not really" case.

When tapping entry (while holding the pointer down) the background of some page, ALL the controls get focus. This can be seen with the entry getting darker: android-entry

And, I have also noticed this in some cases - the WHOLE PAGE gets a ripple??? android-ripples

I can't reliably reproduce that one, but it happens. And, as a page can't get focus, this might be some event we are adding somewhere? Maybe we are making the wrong thing "focusable"?

Contributor guide

Research direction
Investigate fast renderer and focus handling for Material controls on Android. Look at how focus events are propagated in Xamarin.Forms and whether the 'fast renderer' causes incorrect focus visuals. Check if certain controls are mistakenly made focusable.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
C#Xamarin.FormsAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30