xamarin/Xamarin.Forms

Image button on UWP not going back to normal state

Open

#4,910 opened on Jan 7, 2019

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/imagebuttone/3 :clock3:help wantedp/UWPt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

On UWP ImageButton does not go back to Normal state when clicked. It is strange, because it works only when DisplayAlert is called from within Clicked method.

Steps to Reproduce

  1. Download https://github.com/davidortinau/TheLittleThingsPlayground
  2. Remove line 26 from file ThreeFourPage.xaml (Clicked="ImageButton_Clicked")
  3. Run the app
  4. If you click the image button, it will not go back to normal state

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE: Visual Studio: 15.9.3
  • Platform Target Frameworks:
    • UWP: 16299
  • Nuget Packages: Xamarin Forms: 3.4.0.1009999 and 3.4.0.1008975
  • Affected Devices: Desktop application

Contributor guide

Research direction
Investigate the UWP visual state management for ImageButton. Check if the VisualStateManager is properly handling the Pressed state and return to Normal state. Look at the Xamarin.Forms source code for the UWP renderer of ImageButton and trace the click event handling.
Tech stack
csharp
Domain
mobiledesktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsUWP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60