xamarin/Xamarin.Forms

ImageCell line Separator not Rendering properly on iOS ListView

Open

#4,711 opened on Dec 12, 2018

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/listviewe/2 :clock2:good first issuehelp wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When using an ImageCell in a ListView, and all the properties of the ImageCell are set, specifically the ImageSource, the list item separator is not shown.

Creating a custom ViewCell with a a grid and an Image to emulate a similar layout doesn't have the same issue. The list item separator is rendered fine.

Steps to Reproduce

  1. Create ListViewXAML or Code)
  2. Create an ImageCell
  3. Set the Text, Detail and Image Source

Expected Behavior

All list items should be separated by a grey line separator

Actual Behavior

No list items are separated by a grey line separator. When pulling the listview down to force a repaint of the top list items, the line is drawn only for the first 2 items.

Basic Information

  • Version with issue: 3.4.0.1008975
  • Last known good version: /
  • IDE: Visual Studo for Mac
  • Platform Target Frameworks:
    • iOS:
  • Nuget Packages: Xamarin.Forms
  • Affected Devices:

Screenshots

image

image

Reproduction Link

This can be reproduced using the Xamarin University Example XAM280 (Exercise 5 complete) Or download my source code on github: https://github.com/rogerwcpt/xamarin-forms-list-app

Contributor guide

Research direction
Inspect the iOS renderer for ImageCell in Xamarin.Forms. Focus on the list separator drawing logic; check if the separator is being overlapped or not drawn when ImageSource is set. Compare with default ViewCell renderer.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60