xamarin/Xamarin.Forms

[iOS] ToolbarItems with Icons won't align properly

Open

#3,513 opened on Aug 8, 2018

View on GitHubContributor guide
 (17 comments) (8 reactions) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedm/high impact :black_large_square:p/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

While working fine on both Android and UWP, iOS is unable to render ToolbarItems with icons properly.

Steps to Reproduce

  1. Fill a ContentPage's toolbar with 1 or more ToolbarItems, each with a .png Icon
  2. Navigate to the ContentPage wrapped in a NavigationPage

Expected Behavior

ToolbarItems with their respective Icons are aligned to the right like on Android.

Actual Behavior

ToolbarItems scramble around the Navigation Bar, they never appear aligned to the right properly. They are still usable and can trigger Commands.

Basic Information

  • Version with issue: 3.1.0.697729
  • Last known good version: -
  • IDE: Visual Studio Enterprise 15.7.4
  • Platform Target Frameworks:
    • iOS: 11.4 & 11.4.1
  • Nuget Packages: Xamarin.Forms 3.1.0.697729
  • Affected Devices: reproduced on iPhone 6s, iPhone 7, iPhone X

Screenshots

image-1

Reproduction Link

ToolbarBug.zip

Contributor guide

Research direction
Inspect the iOS custom renderer for ToolbarItem to understand how icons are positioned, and compare with Android/UWP implementations to fix alignment.
Tech stack
csharp
Domain
mobilefrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75