xamarin/Xamarin.Forms

Toolbar button not shown on App startup

Open

#2,118 opened on Mar 16, 2018

View on GitHub
 (9 comments) (3 reactions) (0 assignees)C# (1,926 forks)batch import
e/5 :clock5:help wantedm/high impact :black_large_square:p/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

On Android "SetSupportActionBar()" has to be set to be able to intercept "OnOptionsItemSelected()". When not setting "SetSupportActionBar()" the function "OnOptionsItemSelected()" in MainActivity will not be triggered.

Unfortunately after adding this line of code the toolbar item is not shown at the first page after startup (MainPage). The toolbar item will appear after navigating to a different page and back to MainPage.

Steps to Reproduce

  1. Start App. Expected: Toolbar item "About" should be present Actual: No toolbar item is present

  2. Navigate to second page via button

  3. Navigate back via toolbar. This works and "OnOptionsItemSelected()" is triggered. Expected and Actual: Toolbar item "About" is now shown on MainPage and is working.

Basic Information

  • Version with issue: 2.5.0.280555

  • Last known good version:

  • IDE:

  • Platform Target Frameworks:

    • Android: 8.1 (but bug was in earlier releases, too

  • Android Support Library Version: 27.0.2

  • Affected Devices: Tested on Samsung Galaxy Tab S2 (Android 7.0), Google Pixel (Android 8.0)

Reproduction Link

https://github.com/TheSprigg/Toolbarbutton_not_shown/

Contributor guide

Research direction
Investigate the lifecycle of toolbar initialization in Xamarin.Forms for Android and ensure that SetSupportActionBar is called before the toolbar items are added. Check if the toolbar button is being added in the correct page lifecycle method.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40