xamarin/Xamarin.Forms

Listview.ItemTapped doesnt fire when viewcell has ContxctAction and GestureRecognizer

Open

#2,026 opened on Mar 6, 2018

View on GitHub
 (10 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
a/gestures 🖖a/listviewe/8 :clock8:help wantedp/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

ItemTapped event is not fired when a viewcell has contextaction + an element that has a gestrurerecognizer.

On earlier versions of 2.5.0 the issue with this combo was that the contextAction fired just by scrolling the screen (should only fire when longtap), the fix for this issue is here https://github.com/xamarin/Xamarin.Forms/pull/1441.

Now that the fix mentioned is included, Taps doesnt work (with the same combo of viewcell)

Steps to Reproduce

  1. Run Repro (has instructions and is extremely basic)

Expected Behavior

Tapevent should fire

Actual Behavior

Tapevent doesnt fire

Basic Information

  • Version with issue: 2.5.1-pre1
  • Last known good version: 2.4.X
  • IDE: Visual Studio 2017
  • Affected Devices: Android (only tested on android)

Reproduction Link

listtap.zip

Contributor guide

Research direction
Reproduce the issue using the provided sample, trace the event flow for ItemTapped and gesture recognizers, and identify where the event is being suppressed.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65