xamarin/Xamarin.Forms

Button text does not truncate

Open

#1,812 opened on Feb 6, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/layoute/7 :clock7:help wantedp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Bug report best practices: https://github.com/xamarin/Xamarin.Forms/wiki/Submitting-Issues

Description

Migrating https://bugzilla.xamarin.com/show_bug.cgi?id=59262

Button text does not truncate. If the buttons are in a grid, on Android, it works, on iOS it does not. If the buttons are in a stacklayout, it does not work on both Android and iOS.

Steps to Reproduce

  1. Run app Note that on Android, the button text is truncated, and that on iOS it is not.
  2. Change MainPage to new stackbutton(); Run App (this uses a stacklayout instead of grid)
  3. Note that the button does not truncate on both iOS and Android

Expected Behavior

Button text is truncated

Actual Behavior

Button text is not truncated

Basic Information

  • Version with issue: 2.5.0.122203
  • Last known good version: N/A
  • IDE: VS2017
  • Platform Target Frameworks:
    • iOS: yes
    • Android: yes
    • UWP: not tested
  • Android Support Library Version: 25
  • Nuget Packages: just forms
  • Affected Devices: tested on nexus 5x on Android 7, and iphone 5s simulator on iOS 9.3

Screenshots

https://imgur.com/a/NCbN2

Reproduction Link

https://www.dropbox.com/s/d25272c3mzewksf/btnsampletruncate.zip?dl=0

Contributor guide

Research direction
Investigate the iOS custom renderer for Button and compare with Android's handling of text truncation. Look at LineBreakMode and Truncation settings in iOS native UILabel.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40