xamarin/Xamarin.Forms

Current Application gets overridden, causes application level resources to disappear

Open

#1,418 opened on Dec 18, 2017

View on GitHub
聽(6 comments)聽(0 reactions)聽(0 assignees)C#聽(5,644 stars)聽(1,926 forks)batch import
a/embedding 馃摝e/2 :clock2:good first issuehacktoberfest 馃嵒help wantedp/Androidp/UWPp/iOS 馃崕t/bug :bug:up-for-grabs

Description

Use case forms embedding, with application level staticresources:

  • Create a new XF page
  • Call CreateViewController
  • Present the VC the native way.

In this case the existing current XF application gets overridden with an empty one at https://github.com/xamarin/Xamarin.Forms/blob/4c8f901e2333ac1baae818ead61c93559f39758d/Xamarin.Forms.Platform.iOS/PageExtensions.cs#L15

Normally the RealParent would be set when assiging main page. But with embedding this is not used. The code should check wether there is a current XF application before overwriting it.

A workaround until this is fixed is setting the parent manually

var xfPage = new XfPage();
xfPage.Parent = Xamarin.Forms.Application.Current;
var naviteVC = xfPage.CreateViewController();

Contributor guide

Tech stack
csharp
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Xamarin.Forms basicsiOS platform embedding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the file Xamarin.Forms.Platform.iOS/PageExtensions.cs at line 15. The issue is that the code unconditionally creates a new Application instance, overwriting the current one. The fix involves checking if Application.Current is already set before assigning. Review the workaround mentioned in the issue: setting Parent manually. Also consider comments in the issue for additional context and potential edge cases.
Current Application gets overridden, causes application level resources to disappear 路 xamarin/Xamarin.Forms#1418 | Good First Issue