xamarin/Xamarin.Forms

[UWP] TapGestureRecognizer No Longer Blocks List View Item Tapped Event

Open

#1,406 opened on Dec 14, 2017

View on GitHubContributor guide
 (14 comments) (2 reactions) (0 assignees)C# (1,926 forks)batch import
a/gestures 🖖a/listviewe/6 :clock6:help wantedp/UWPt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

TapGestureRecognizers inside the view cell of a list view no longer block the item tapped/item selected event of a list view.

Steps to Reproduce

  1. Create a list view with item tapped and or item selected events.
  2. Have a control with a tap gesture recognizer inside the view cell.
  3. Tap gesture recognizer doesn't block item tapped / item selected events.

Expected Behavior

The TapGestureRecognizer should block the item tapped / item selected event from firing. This use to be the behavior.

Actual Behavior

Both the TapGestureRecognizer and the item tapped / item selected events fire.

Basic Information

  • Version with issue: 2.5.0.121934
  • Last known good version: 2.3.4.270
  • IDE: VS 2017 15.5.1
  • Platform Target Frameworks:
    • UWP: 15063
  • Nuget Packages: Xamarin Forms
  • Affected Devices: UWP

Reproduction Link

Here is a reproduction solution https://drive.google.com/file/d/1iud-OgALmeTw1Jf1q6xKMGG00v2xsNhF/view?usp=sharing

https://bugzilla.xamarin.com/show_bug.cgi?id=32842

Contributor guide

Research direction
Investigate the regression between Xamarin.Forms 2.3.4 and 2.5.0 on UWP to identify changes that caused TapGestureRecognizer to stop blocking ListView item tapped events.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.FormsUWP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70