javascript-testing-patterns
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- documentation
Research direction
Open plugins/javascript-typescript/skills/javascript-testing-patterns/SKILL.md and inspect the example around line 87. Confirm how the divide example is presented relative to pure functions, then update the example or its classification so the skill accurately distinguishes the behavior. Done means the testing-pattern guidance is idiomatic and consistent with the stated example.
Written by the indexing model from the issue text.
Description
Preliminary Checks
- I have read the Code of Conduct
- I have searched existing issues to ensure this is not a duplicate
- This is a constructive feature request for legitimate use cases
Scope
Existing plugin / agent / skill / command (improvement)
Target component (if scope is plugin/agent/skill/command)
javascript-testing-patterns
Problem description
the example https://github.com/wshobson/agents/blob/4236bb91f8395b0435f1d8b8baf9e8e4c69a8620/plugins/javascript-typescript/skills/javascript-testing-patterns/SKILL.md?plain=1#L87 is suppose to give examples to test pure functions however the divide function is not pure since its throwing an error
Proposed solution
the divide function example can be an example of impure functions
Use cases
not that important since most LLM's would understand this , but to make the skill a bit more idiomatic thats all
Alternatives considered
NA
Additional context
No response
- Dominant language
- Python
- Stars
- 39.8k
- Forks
- 4.2k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 20
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from wshobson/agents
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
-
Difficulty 4/5 3-5 days Newbie friendliness 62/100
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100