Toggle pre is not working

Open
#1,380 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
swift
Domain
mobile

Research direction

Start by reproducing the behavior shown in the attached video with the example button changed to call togglePre(range: NSRange). Read the togglePre(range: NSRange) implementation and compare its on/off behavior with toggleCode(range: NSRange). Done means the pre tag can be both enabled and disabled for the selected range.

Written by the indexing model from the issue text.

Description

Hello, can you help me?
The project is just fine, but there is one problem that I couldn't solve on my own. Your togglePre(range: NSRange) method is not working.
I attach a video of your example, in which I changed the button responsible for the toggleCode(range: NSRange) method to togglePre(range: NSRange). The pre tag is turned on, but it is not turned off anymore.

https://github.com/wordpress-mobile/AztecEditor-iOS/assets/75531082/74d92e2d-1fff-446c-92e4-c8100fb0beef

Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from wordpress-mobile/AztecEditor-iOS

All issues in wordpress-mobile/AztecEditor-iOS

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.