aDecoder.decodeInteger on nullable int causes crash

Open
#1,331 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
swift
Domain
mobile

Research direction

Start in Aztec/Classes/TextKit/ParagraphProperty/TextList.swift, at the decoding line around 64 and the nullable value encoded around line 83. Reproduce copy-pasting a list with HTML pasting disabled, then verify that decoding the nullable integer no longer crashes.

Written by the indexing model from the issue text.

Description

[Bug-Type] Crash / Blocker

In my fork, I disabled html pasting, which causes a crash when the user tries to copy-paste lists.
This is because Aztec might encode a nil-int when performing the copy: https://github.com/wordpress-mobile/AztecEditor-iOS/blob/e0cb3c96ada0bed9fab5d3e93952e8375b29d97e/Aztec/Classes/TextKit/ParagraphProperty/TextList.swift#L83

Now, when pasting, a crash occurs here because it expects a non-nil-int: https://github.com/wordpress-mobile/AztecEditor-iOS/blob/e0cb3c96ada0bed9fab5d3e93952e8375b29d97e/Aztec/Classes/TextKit/ParagraphProperty/TextList.swift#L64

This can be fixed by changing that line to:

let decodedStart = aDecoder.decodeObject(forKey: AttributeType.start.rawValue) as? Int
Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from wordpress-mobile/AztecEditor-iOS

All issues in wordpress-mobile/AztecEditor-iOS

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.