Pasting doesn't call notifyTextViewDidChange

Open
#1,330 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
swift
Domain
mobile

Research direction

Start in Aztec/Classes/TextKit/TextView.swift at the two paste-related lines linked in the issue. Confirm how those paths handle pasted content and where notifyTextViewDidChange is currently called. Done means pasting text informs the delegate through textViewDidChange.

Written by the indexing model from the issue text.

Description

[Type] Bug

Describe the bug
When pasting text/content/... into the TextView, the delegate should be informed / textViewDidChange should be called

Expected behavior
notifyTextViewDidChange is called / the delegate is informed about the text change

Proposed fix
Call notifyTextViewDidChange in these 2 lines:

https://github.com/wordpress-mobile/AztecEditor-iOS/blob/dbe6a0a5ec03f2ff93ab580b043ec0f33db2abf2/Aztec/Classes/TextKit/TextView.swift#L513

https://github.com/wordpress-mobile/AztecEditor-iOS/blob/dbe6a0a5ec03f2ff93ab580b043ec0f33db2abf2/Aztec/Classes/TextKit/TextView.swift#L520

Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from wordpress-mobile/AztecEditor-iOS

All issues in wordpress-mobile/AztecEditor-iOS

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.