New line / Line Break after added new image in the editor

Open
#1,276 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ios, swift
Domain
mobile

Research direction

Reproduce the issue using the listed steps, then trace insertImage(_:), especially richTextView.replaceWithImage(at:sourceURL:placeHolderImage:) and the subsequent selection handling. Confirm that inserting an image leaves the cursor on the following line without requiring a keyboard return, while preserving the attachment and link behavior shown.

Written by the indexing model from the issue text.

Description

[Type] Question

Describe the bug
Need to move the cursor to next line after i added image in the editor. Now, the cursor is right side of image.
Tried to add " \n and br tag " like below

func insertImage(_ image: UIImage) {
        let attachment = richTextView.replaceWithImage(at: richTextView.selectedRange, sourceURL: fileURL!, placeHolderImage: image)
        attachment.size = .full
        attachment.alignment = ImageAttachment.Alignment.none
        if let attachmentRange = richTextView.textStorage.ranges(forAttachment: attachment).first {
            richTextView.setLink(fileURL!, inRange: attachmentRange)
        }
        
        richTextView.becomeFirstResponder()
//        richTextView.text = richTextView.text + "\n"
//        editorView.setHTML(editorView.getHTML()+"</p>\n<p>")
        
        let imageID = attachment.identifier
        let progress = Progress(parent: nil, userInfo: [MediaProgressKey.mediaID: imageID])
        progress.totalUnitCount = 100
    }
//        editorView.setHTML(editorView.getHTML()+"</p>\n<p>")
//        richTextView.text = richTextView.text + "\n"

Nothing worked.

To Reproduce
Steps to reproduce the behavior:

  1. Type some text
  2. Click + button to open image picker, choose image
  3. Image added in editor but the cursor in right side of image
  4. Need to press return button in the keyboard to make the cursor to come next line. But, how i can make it programmatically to move next line

Expected behavior
Need to press return button in the keyboard to make the cursor to come next line. But, how i can make it programmatically to move next line

Smartphone (please complete the following information):

  • Device: iOS
Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from wordpress-mobile/AztecEditor-iOS

All issues in wordpress-mobile/AztecEditor-iOS

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.