woocommerce/woocommerce

wp-content hardcoded instead of using WP_CONTENT_DIR

Closed

#30898 opened on Oct 7, 2021

View on GitHub
 (5 comments) (2 reactions) (1 assignee)PHP (10,294 stars) (10,695 forks)batch import
BugGood First IssueOrder ManagementRubikplugin: woocommerce

Description

/includes/class-wc-download-handler.php

is using hardcoded wp-content, which is wrong (and gives incorrect results when WP_CONTENT_DIR is not wp-content)

} elseif ( '/wp-content' === substr( $file_path, 0, 11 ) ) {

should be:
} elseif ( '/' . str_replace( ABSPATH, '', WP_CONTENT_DIR ) === substr( $file_path, 0, strlen( str_replace( ABSPATH, '', WP_CONTENT_DIR ) ) + 1 ) ) {

Contributor guide

Tech stack
php
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of WordPress constantsPHP basicsFamiliarity with file paths
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is in /includes/class wc download handler.php. The code uses a hardcoded string '/wp content' to check file paths, which fails when WP CONTENT DIR is different. The fix is to replace the conditional with one that uses the WP CONTENT DIR constant and ABSPATH to dynamically compute the relative path. The issue has an assignee, so check if a PR is already in progress. Review the file to understand the context and ensure the replacement handles all edge cases.