withastro/astro

馃悰 BUG: SASS content incorrectly highlighted as CSS syntax when `lang='sass'` is not on the same line with `<style`

Open

#14,657 opened on Jan 17, 2025

View on GitHub
聽(6 comments)聽(0 reactions)聽(0 assignees)TypeScript聽(59,282 stars)聽(3,444 forks)batch import
- P2: nice to havefeat: syntaxgood first issuepkg: language-tools

Description

Describe the Bug

When the lang attribute of the <style> tag is not on the same line as the style tag, the content may be incorrectly highlighted as CSS syntax.

Steps to Reproduce

  1. npm create astro@latest
  2. open the project in vscode
  3. install newest astro extension
  4. create anyname.astro with the contents
<style
  lang="sass"
  define:vars={{
    // any comment to avoid formatter collapse content into a single line
    foo: '#fff',
  }}
>
  .bar
    color: var(--foo)
</style>
  1. the content below .bar (include </style>) will be incorrectly highlighted as css syntax, not sass.

Link to Minimal Reproducible Example

https://gist.github.com/HPCesia/6e935433cfd6e414099f71714cb4961d

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Astro syntaxFamiliarity with VSCode extension grammar files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The bug is in the Astro VSCode extension's TextMate grammar for style tags. The grammar currently assumes the lang attribute is on the same line as the opening <style tag. To fix, update the grammar to handle multiline attributes by using a pattern that allows newlines between <style and the attribute. Look at the syntaxes/astro.tmLanguage.json file in the withastro/language tools repository. Test the provided example to ensure SASS content is correctly highlighted.