winstonjs/winston

Best way to get highest log level

Open

#837 opened on Mar 24, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (21,967 stars) (1,789 forks)batch import
Feature RequestGood First IssueHelp Wanted

Description

I have a logger where if one of the transports is at 'debug' or higher, it logs a lot more information than would normally be needed. Some of this data requires other processing before it can be logged. So, before logging, I check the highest log level to see if that extra work really needs to be done.

I've been using the following to find the highest log level on a given logger:

winston.Logger.prototype.getHighestLogLevel = function() {
  var result = 0;

  for(var i in logger.transports) {
    result = Math.max(result, logger.levels[logger.transports[i].level || logger.level]);
  }

  return result;
}

Is there a simplified way to do this? If not, would there be a problem with merging this?

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jswinston basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the winston codebase, especially the Logger class, to see if a method like getHighestLogLevel already exists. The provided prototype method can serve as a starting point. Look at the transport's level handling and consider if a simpler API exists. Engage with maintainers in the issue comments to decide on integrating this feature.