winstonjs/winston

3.0.0 winston.query throws exception for File Transport

Open

#1130 opened on Nov 6, 2017

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (21,967 stars) (1,789 forks)batch import
BugGood First IssueHelp Wantedwinston-file

Description

The Functions Transport.prototype.normalizeQuery, Transport.prototype.formatResults and common.clone were removed in 3.0.0, so query will throw an unhandled exception.

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Node.jsFamiliarity with winston transport API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue reports that methods Transport.prototype.normalizeQuery, Transport.prototype.formatResults, and common.clone were removed in winston 3.0.0, breaking query for File transport. To fix, examine the winston source code, particularly lib/winston/transports/transport.js and lib/winston/common.js, to understand the original query logic. Re implement query support for File transport by leveraging file system APIs like fs.createReadStream and manual result formatting. Ensure compatibility with the existing query API contract as documented. Testing should cover various query parameters (e.g., rows, limit, start, order).