winglang/wing

If `--values FILE` is not provided, the `WING_VALUES_FILE` variable is not considered `nil`

Open

#4,982 opened on Nov 17, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (214 forks)github user discovery
good first issue⌨️ cli🐛 bug

Repository metrics

Stars
 (5,385 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I tried this:

bring util;

if let x = util.tryEnv("WING_VALUES_FILE") {
  log(x);
}

This happened:

Prints undefined

I expected this:

Not to print anything if there I didn't specify a values file.

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.

Contributor guide

Research direction
Inspect the code that sets WING VALUES FILE environment variable when no values flag is given. The issue is that it is set to 'undefined' string instead of being left unset.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75