winapps-org/winapps

App detection doesn't work on locals with special characters

Open

#296 opened on Oct 15, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Shell (15,020 stars) (463 forks)batch import
good first issue

Description

The automatic option completes the installation process successfully. However, the Manual (Default) option will cause an error.

The error is Line 79: Join-Path: Command not found.

Looking at the detected file with sudo vim, I can see some unknown characters. Maybe an issue with non-English words?

image

Contributor guide

Tech stack
shell
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with shell scriptingknowledge of character encoding issues
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The error occurs at Line 79 in the detection script where `Join Path` is used. Investigate if the script is using PowerShell commands incorrectly or if the issue is due to special characters in the local path. Look at the code around that line to understand how paths are constructed and consider using alternative methods for path joining that handle special characters. Also, verify if the environment has PowerShell installed and available.