winapps-org/winapps

new setup.sh behaviour breaks installing/reinstalling from a local custom fork

Open

#249 opened on Sep 10, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Shell (15,020 stars) (463 forks)batch import
good first issue

Description

The new behaviour of setup.sh is super unfriendly.

Running setup just re-clones the main repo to ~/.local/winapps-src and intalls from there - regardless of the repo being cloned locally already.

Not only is this doubling up on cloning, but BIG issue here is when you are wanting to install winapps from a custom local fork for testing . The current behaviour effectively ignores all local code, which forces all custom changes to be manually re-added each and every time setup is run.

I really think that setup should try to install from any local repo source first and certainly not ignore or overwrite customisations made to any local code. (This nearly caught me out testing a new PR, as I was thinking I was testing my own new code and all the while I wasn't testing anything new. )

Contributor guide

Tech stack
shell
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
shell scripting basicslocal git fork setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine setup.sh to understand the current cloning logic. Modify it to first check for an existing local clone (e.g., in the current directory or a specified path) and use that source instead of always cloning from the remote. Verify the fix by testing with a custom fork cloned locally to ensure local changes are preserved.
new setup.sh behaviour breaks installing/reinstalling from a local custom fork · winapps-org/winapps#249 | Good First Issue