webtorrent/webtorrent-desktop

Doesn't remember maximized window state

Open

#1560 opened on Mar 29, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (9,423 stars) (1,055 forks)batch import
acceptedbuggood first contributionhelp wanted

Description

What version of WebTorrent Desktop? 0.20.0 (0.98.21) (64bit)

What operating system and version? Window 10 (v1809)

What did you do?

  • Open WebTorrent Desktop
  • Maximize the Window
  • Close (completely)
  • Re-open

What did you expect to happen? Remember the maximized window state after reopening

What actually happened? Opened in resized (default) window state

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ElectronJavaScriptwindow management APIpersistent storage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how window state (position, size, maximized) is currently saved and restored. Likely in main process, check 'main/index.js' or similar. Look for use of 'electron store' or custom JSON file for settings. The fix probably involves saving the maximized state in addition to bounds, and restoring it on app startup.