webtorrent/webtorrent-desktop

Special Characters in Filenames

Open

#1,147 opened on Mar 2, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (1,055 forks)batch import
acceptedbuggood first contributionhelp wanted

Repository metrics

Stars
 (9,423 stars)
PR merge metrics
 (Avg merge 1m) (5 merged PRs in 30d)

Description

On the latest version of webtorrent desktop when I try to seed a torrent that has files whose filename contains characters such as an ellipsis or apostrophe the character is replaced with a question mark character making it impossible to seed the original file without having to rename it and make another torrent altogether. I don't get this though when I create a new torrent using the same file however. Only when the using the .torrent file. I used the same torrent file in several other clients and didn't have this issue.

Contributor guide

Research direction
Inspect how webtorrent desktop decodes filenames from .torrent files (likely using the btparse or similar library) and compare with the encoding used when creating a new torrent. Focus on handling of multi byte UTF 8 characters like ellipsis and apostrophe.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70