webtorrent/webtorrent-desktop

Consider using app.setLoginItemSettings(settings) API instead of auto-launch

Open

#1135 opened on Feb 15, 2017

View on GitHub
 (2 comments) (6 reactions) (0 assignees)JavaScript (9,423 stars) (1,055 forks)batch import
acceptedenhancementgood first contributionhelp wanted

Description

Electron offers an official API for setting the app to start at login. Let's consider using it instead of auto-launch on Windows and Mac.

http://electron.atom.io/docs/api/app/#appsetloginitemsettingssettings-macos-windows

We may need to keep auto-launch around for Linux users.

Contributor guide

Tech stack
javascriptelectronnodejs
Domain
desktop
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Electron APIUnderstanding of auto launch library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the current auto launch implementation in the repository (likely in main process files). Then review the Electron documentation for app.setLoginItemSettings. Implement the changes for Windows and macOS using the official API, and ensure the auto launch library is still used as a fallback for Linux. Test the login behavior on all three platforms. No linked PRs or comments providing additional direction.