webtorrent/webtorrent-desktop

Consider using app.setLoginItemSettings(settings) API instead of auto-launch

Open

#1,135 opened on Feb 15, 2017

View on GitHub
 (2 comments) (6 reactions) (0 assignees)JavaScript (1,055 forks)batch import
acceptedenhancementgood first contributionhelp wanted

Repository metrics

Stars
 (9,423 stars)
PR merge metrics
 (Avg merge 1m) (5 merged PRs in 30d)

Description

Electron offers an official API for setting the app to start at login. Let's consider using it instead of auto-launch on Windows and Mac.

http://electron.atom.io/docs/api/app/#appsetloginitemsettingssettings-macos-windows

We may need to keep auto-launch around for Linux users.

Contributor guide

Research direction
Review the Electron documentation for app.setLoginItemSettings, then replace the auto launch implementation with the official API for Windows and Mac. Keep the existing auto launch code for Linux compatibility.
Tech stack
javascriptnodejs
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70