webtorrent/webtorrent-desktop

Consider autoHideMenuBar browser window option for Linux

Open

#1134 opened on Feb 14, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (9,423 stars) (1,055 forks)batch import
acceptedenhancementgood first contributionhelp wanted

Description

Consider adding autoHideMenuBar to browser window on Linux, since the menu bar frequently looks terrible on non-Unity systems. It shouldn't have an effect on Ubuntu+Unity (the only Linux we officially support) since the menu bar isn't part of the window (it's like macOS).

This change needs to be tested.

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Electron basicsLinux OS for testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Locate where BrowserWindow is instantiated, likely in a main process file such as 'main.js'. Add the 'autoHideMenuBar' option (set to true) only for non Unity Linux systems, as Unity handles the menu bar separately. Verify that the change does not break Ubuntu+Unity by testing on that environment as well. Test on a Linux distribution without Unity (e.g., Fedora with GNOME) to ensure the menu bar is hidden.