encode object didn't support binary(buffer) as obj key

Open
#88 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
networking

Research direction

Start with the object-encoding path in node-bencode and reproduce the BitTorrent scrape case using a binary infohash as an object key. Confirm the encoder handles Buffer keys and add regression coverage for that case.

Written by the indexing model from the issue text.

Description

bittorrent scrape need to use infohash as key, it is a binary.

Dominant language
JavaScript
Stars
173
Forks
38
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from webtorrent/node-bencode

All issues in webtorrent/node-bencode

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.